I think we’ve all worked with people that fall into these when it comes to PR time.
Smart and energetic - "I think this covers everything functionally and I’ve added a couple of extra unit tests for the functions I had to refactor”
Smart and lazy - "This covers everything but I’ll add the unit tests in a follow up PR shortly" [never happens]
Dumb and energetic - "Can you review this ASAP please, it’s only small, shouldn’t have any bugs or issues. I just need to get this in because <manager> is looking for this feature ASAP. I will fix any issues in a follow up PR." [prod issue w/ feature after go-live]
Dumb and lazy - <Raises PR, fails CI tests, doesn’t respond to any feedback for a week> [feature 3 weeks late]
Smart and energetic - "I think this covers everything functionally and I’ve added a couple of extra unit tests for the functions I had to refactor”
Smart and lazy - "This covers everything but I’ll add the unit tests in a follow up PR shortly" [never happens]
Dumb and energetic - "Can you review this ASAP please, it’s only small, shouldn’t have any bugs or issues. I just need to get this in because <manager> is looking for this feature ASAP. I will fix any issues in a follow up PR." [prod issue w/ feature after go-live]
Dumb and lazy - <Raises PR, fails CI tests, doesn’t respond to any feedback for a week> [feature 3 weeks late]
I guess pick your poison on the last 2?